Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Max msgs per subject config update to lower values #4446

Merged
merged 1 commit into from Aug 29, 2023

Conversation

derekcollison
Copy link
Member

We were not recalculating first correctly since we were not considering seq < mb.first.seq.

Signed-off-by: Derek Collison derek@nats.io

Resolves #4445

…king for seq < mb.first.seq

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner August 29, 2023 23:24
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit abf5e0b into main Aug 29, 2023
2 checks passed
@derekcollison derekcollison deleted the issue-1382 branch August 29, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants