Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] potential message duplication from sources when downgrading back from 2.10 #4454

Merged
merged 1 commit into from Aug 30, 2023
Merged

[FIXED] potential message duplication from sources when downgrading back from 2.10 #4454

merged 1 commit into from Aug 30, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Aug 30, 2023

  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

2.10 adds a couple space separated fields to the sourcing message header from 2 to 4 but the current 2.9 code is too strict of checking the number of fields is exactly 2 rather than at least 2

@jnmoyne
Fixes possible message duplication in sourcing streams if upgrading t…
003daf3 
…o 2.10 and then back down to 2.9

2.10 adds a couple space separated fields to the sourcing message header from 2 to 4 but the current 2.9 code is too strict of checking the number of fields is exactly 2 rather than at least 2

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
@jnmoyne jnmoyne requested a review from a team as a code owner August 30, 2023 22:29
derekcollison
derekcollison approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2e1392a into main Aug 30, 2023
2 checks passed
@derekcollison derekcollison deleted the jnm/fix_30Aug23 branch August 30, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnmoyne @derekcollison