Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaf connection missing LS+ sometimes #4464

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix leaf connection missing LS+ sometimes #4464

merged 1 commit into from Aug 31, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 31, 2023 •
edited

TestNoRaceLeafNodeSmapUpdate could occasionally fail with missing LS+ commands due not capturing all the inflight SUB commands as they were being processed outside the client lock.

@kozlovic @wallyqs
Fix leaf connection missing LS+ sometimes
9a9e84e 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner August 31, 2023 17:30
derekcollison
derekcollison approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks to you both.

@wallyqs wallyqs merged commit 76c3942 into main Aug 31, 2023
2 checks passed
@wallyqs wallyqs deleted the leaf-ls-sl-race branch August 31, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @derekcollison @kozlovic