[IMPROVED] Consumer failing to deliver re-adjusts delivered count and any waiting request. #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otDeliver() or LoadMsg() failure re-adjust delivered count and waitingRequest accounting. Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
approved these changes
Sep 1, 2023
server/consumer.go
Outdated
| if err == ErrStoreMsgNotFound || err == errDeletedMsg || err == ErrStoreEOF || err == errMaxAckPending { | ||
| goto waitForMsgs | ||
| } else if err == errPartialCache { | ||
| s.Warnf("Unexpected partial cache error looking up message for consumer") |
There was a problem hiding this comment.
Can we put the consumer name in this error?
There was a problem hiding this comment.
Good idea, should we do same for err below?
There was a problem hiding this comment.
ok pushed second CL for that. Take a look.
E.g. `Unexpected partial cache error looking up message for consumer '$G > TEST > dlc'` Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to deliver a message for a consumer, either through didNotDeliver() or LoadMsg() failure re-adjust delivered count and waitingRequest accounting.
Signed-off-by: Derek Collison derek@nats.io