Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to control sync intervals and sync always #4483

Merged
merged 1 commit into from Sep 4, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner September 4, 2023 05:32
@ripienaar
Copy link
Contributor

Be good if this setting is surfaced somewhere like JetStreamVarz.Config fetched via varz

@derekcollison
Copy link
Member Author

Will make sure its returned.

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison
Copy link
Member Author

ok added in the jsz / varz and additional test to watch needSync flag etc.

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…s synchronous.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit bf7b4b8 into dev Sep 4, 2023
2 checks passed
@derekcollison derekcollison deleted the sync-always branch September 4, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants