Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Data race, protect access to c.acc #4550

Merged
merged 1 commit into from Sep 17, 2023
Merged

[FIXED] Data race, protect access to c.acc #4550

merged 1 commit into from Sep 17, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

Resolves #4549

@derekcollison
Protect access to c.acc
4e9cd9a 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner September 17, 2023 17:02
Jarema
Jarema approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 6f38056 into main Sep 17, 2023
2 checks passed
@derekcollison derekcollison deleted the fix-4549 branch September 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition reading c.acc.Name in events.go accountConnectEvent
2 participants
@derekcollison @Jarema