Use new consumer create subject when single subject filter specified in SubjectFilters
#4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/filtersubject
branch
from
1f825a8
to
cb6b6ce
Compare
|
LGTM |
neilalexander
force-pushed
the
neil/filtersubject
branch
from
cb6b6ce
to
e98dfc8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
LGTM - let's get those test flappers fixed and light the candle. |
|
This test (at least) is truly broke, so we need to fix it. |
|
The change introduced a breaking behavior. |
neilalexander
force-pushed
the
neil/filtersubject
branch
from
3dc6b14
to
946df26
Compare
…in `SubjectFilters` Signed-off-by: Neil Twigg <neil@nats.io>
The server consumer creation code is picky and does indeed not accept a request send to the ExT subject if that request specifies the subject filter in the array (even if there is only one entry in the array). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com> Co-authored-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/filtersubject
branch
from
946df26
to
40ce0a9
Compare
|
Have added a comment explaining what is happening and rebased to top of Thanks @jnmoyne for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where specifying a single subject filter, i.e. in
SubjectFiltersorSubjectTransforms, instead of usingSubjectFilterwould result in the old consumer create subject being incorrectly used.Signed-off-by: Neil Twigg neil@nats.io