Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] LeafNode: TLS Handshake when remote does not have a tls{} block #4565

Merged
merged 1 commit into from Sep 20, 2023

Conversation

kozlovic
Copy link
Member

If a leafnode remote configuration does not have a tls{} block but connect to a hub that requires TLS, the handshake between the two servers will fail. A simple workaround is to add in the remote configuration an empty tls{} block.

This issue was introduced in v2.10.0 due to some refactoring in order to support compression.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

If a leafnode remote configuration does not have a tls{} block but
connect to a hub that requires TLS, the handshake between the two
servers will fail. A simple workaround is to add in the remote
configuration an empty tls{} block.

This issue was introduced in v2.10.0 due to some refactoring in
order to support compression.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner September 20, 2023 02:04
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks.

@derekcollison derekcollison merged commit 29ba4aa into main Sep 20, 2023
2 checks passed
@derekcollison derekcollison deleted the fix_leafnode_tls branch September 20, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants