Fix consumer limits #4567
Merged
Fix consumer limits #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test didn't catch this error, as by default, old JS client sets ack policy to none. If policy is different, it will fail to create consumer with defaults. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Stream has consumer limits set, creating consumer with defaults will fail in most cases.
Test didn't catch this, as by default, old JS client sets ack policy to
none. If the policy is different, it will fail to create consumer with defaults. We agreed that default Ack Policy should beexplicitSigned-off-by: Tomasz Pietrek tomasz@nats.io