Set S2 writer concurrency to 1 #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/s2concurrency
branch
from
86e37d2
to
d4e8a44
Compare
derekcollison
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the S2 library defaults to a concurrency level of
GOMAXPROCS, which forces the library to run extra goroutines to manage asynchronous flushes.As we only ever have one goroutine (the client writer) using a given S2 writer, reducing the concurrency down to 1 helps a bit with overheads, slightly reduces allocations and slightly improves throughput.
Signed-off-by: Neil Twigg neil@nats.io