Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] We will panic since we unlock the mb in removeMsgBlock #4571

Merged
merged 1 commit into from Sep 22, 2023
Merged

[FIXED] We will panic since we unlock the mb in removeMsgBlock #4571

merged 1 commit into from Sep 22, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
We will panic since we unlock the mb in removeMsgBlock
21e81a2 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner September 22, 2023 01:35
wallyqs
wallyqs approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 24fe082 into main Sep 22, 2023
2 checks passed
@derekcollison derekcollison deleted the fs-unlock branch September 22, 2023 01:57
@kozlovic
Copy link
Member

Looks like there is one more place where fs.removeMsgBlock() is invoked without the mb's lock, is that ok? I am thinking of rebuildFirst()..

@derekcollison
Copy link
Member Author

Thanks will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @kozlovic @wallyqs