Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nats-general links #4590

Merged
merged 1 commit into from Sep 26, 2023
Merged

Fix nats-general links #4590

merged 1 commit into from Sep 26, 2023

Conversation

jdhenke
Copy link
Contributor

@jdhenke jdhenke commented Sep 26, 2023 •
edited

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves #

Changes proposed in this pull request:

  • Fixes links to the nats-general repository.

@jdhenke jdhenke requested a review from a team as a code owner September 26, 2023 11:39
@jdhenke
Copy link
Contributor Author

jdhenke commented Sep 26, 2023

The link in MAINTAINERS.md was broken, and then I noticed other nats-general links referenced master instead of main so changed those as well.

Let me know if I should submit this differently / adjust the summary. Wasn't sure what to do because this wasn't a code change.

derekcollison
derekcollison approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@derekcollison derekcollison merged commit 27049a9 into nats-io:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdhenke @derekcollison