Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Additional markers for dirty state #4601

Merged
merged 1 commit into from Sep 28, 2023
Merged

[IMPROVED] Additional markers for dirty state #4601

merged 1 commit into from Sep 28, 2023

Conversation

derekcollison
Copy link
Member

Under certain circumstances we could delay recovery if the state file pointed to an absent msg block.
Found additional places to mark dirty and optionally kick the flusher.

Signed-off-by: Derek Collison derek@nats.io

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner September 28, 2023 03:33
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 89c2c84 into main Sep 28, 2023
2 checks passed
@derekcollison derekcollison deleted the fs-dirty branch September 28, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants