systemd: use SIGUSR2 for shutdown, for LDM #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
approved these changes
Sep 28, 2023
derekcollison
approved these changes
Sep 28, 2023
|
Someone would have to actually use this util/ |
|
Oh yes they do. Without any edits. |
JulienVdG
reviewed
Oct 25, 2023
Comment on lines
9
to
+14
| ExecStop=/bin/kill -s SIGINT $MAINPID | ||
| User=nats | ||
| Group=nats | ||
| # The nats-server uses SIGUSR2 to trigger using Lame Duck Mode (LDM) shutdown | ||
| KillSignal=SIGUSR2 | ||
| # You might want to adjust TimeoutStopSec too. |
There was a problem hiding this comment.
Hello, sorry for the late message, I only saw the change when browsing the release notes.
Shouldn't the ExecStop command also be updated to send SIGUSR2 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: