Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more pprof labels to consumers, sources, mirrors #4609

Merged
merged 1 commit into from Sep 29, 2023
Merged

Add more pprof labels to consumers, sources, mirrors #4609

merged 1 commit into from Sep 29, 2023

Conversation

neilalexander
Copy link
Member

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner September 29, 2023 16:15
derekcollison
derekcollison approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander marked this pull request as draft September 29, 2023 17:01
@neilalexander
Copy link
Member Author

Moving back to draft until I've had the time to look at TestJetStreamClusterGhostEphemeralsAfterRestart, which is probably related to the start goroutine changes.

@neilalexander
Add more pprof labels to consumers, sources, mirrors
212d92c 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander marked this pull request as ready for review September 29, 2023 18:13
derekcollison
derekcollison approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 15b4611 into main Sep 29, 2023
2 checks passed
@neilalexander neilalexander deleted the neil/morelabels branch September 29, 2023 18:38
@neilalexander neilalexander self-assigned this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees

@neilalexander neilalexander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neilalexander @derekcollison