Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Reduce contention for high connections in a JetStream enabled account with high API usage. #4613

Merged
merged 1 commit into from Oct 1, 2023

Conversation

derekcollison
Copy link
Member

Several strategies are used which are listed below.

  1. Checking a RaftNode to see if it is the leader now uses atomics.
  2. Checking if we are the JetStream meta leader from the server now uses an atomic.
  3. Accessing the JetStream context no longer requires a server lock, uses atomic.Pointer.
  4. Filestore syncBlocks would hold msgBlock locks during sync, now does not.

Signed-off-by: Derek Collison derek@nats.io

…m enabled account with high API usage.

Several strategies which are listed below.

1. Checking a RaftNode to see if it is the leader now uses atomics.
2. Checking if we are the JetStream meta leader from the server now uses an atomic.
3. Accessing the JetStream context no longer requires a server lock, uses atomic.Pointer.
4. Filestore syncBlocks would hold msgBlock locks during sync, now does not.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner September 30, 2023 22:40
Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good amount of subtle clean-up.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 0083928 into main Oct 1, 2023
2 checks passed
@derekcollison derekcollison deleted the contention branch October 1, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants