Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVED] Memory growth on compressed websocket connections. #4620

Merged
merged 1 commit into from Oct 3, 2023

Conversation

derekcollison
Copy link
Member

Holding onto the compressor and not recycling the internal byte slice could cause havoc with GC.

This needs to be improved but this at least should allow the GC to cleanup more effectively.

Signed-off-by: Derek Collison derek@nats.io

… was causing havoc with GC.

This needs to be improved but this at least should allow the GC to cleanup more effectively.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit 21e2723 into main Oct 3, 2023
2 checks passed
@derekcollison derekcollison deleted the ws-compress branch October 3, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants