Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip processing consumer assignments after JS has shutdown #4625

Merged
merged 1 commit into from Oct 4, 2023
Merged

Skip processing consumer assignments after JS has shutdown #4625

merged 1 commit into from Oct 4, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Oct 4, 2023 •
edited

This avoids following events happening after calling lame duck shutdown:

[20] 2023/10/04 18:49:58.456838 [INF] JetStream Shutdown
...
[20] 2023/10/04 18:50:02.252947 [WRN] Consumer assignment for 'js > testStream:30 > P3xF2q4d00pYr4ACgNBf9F' not cleaned up, retrying

[21] 2023/10/01 04:42:23.552141 [INF] Initiating JetStream Shutdown...
[21] 2023/10/01 04:42:23.557252 [WRN] Consumer create failed, could not locate stream 'js > test:0 > A-0-1'
[21] 2023/10/01 04:42:23.557273 [WRN] Consumer create failed, could not locate stream 'js > test:0 > A-0-2'
[21] 2023/10/01 04:42:23.557278 [WRN] Consumer create failed, could not locate stream 'js > test:0 > A-0-3'

@wallyqs
Skip processing consumer assignments after JS has shutdown
ffac28b 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner October 4, 2023 19:01
derekcollison
derekcollison approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 4e414f1 into main Oct 4, 2023
2 checks passed
@wallyqs wallyqs deleted the consumer-create-failed branch October 4, 2023 20:17
neilalexander pushed a commit that referenced this pull request Feb 26, 2024
@wallyqs @neilalexander
Skip processing consumer assignments after JS has shutdown (#4625)
30ca7a7 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wallyqs @derekcollison