Fix updating a non unique consumer on workqueue stream not returning an error #4654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #4653.
Changes made:
func (*stream).partitionUnique(partitions []string) bool
to accept the consumer name being checked so we can skip it while checking for overlapping subjects (Required forFilterSubjects
updates), wasn't needed before because the checks were made on creation only.There's only 1 thing that I'm not sure about.
In the current work queue stream conflict checks, the consumer config
Direct
is being checked iffalse
, should we also make this check before the update?Signed-off-by: Pierre Mdawar pierre@mdawar.dev