Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Stream / KV lookups fail after decreasing history size. #4656

Merged
merged 1 commit into from Oct 12, 2023

Conversation

derekcollison
Copy link
Member

Fixed a bug that was not correctly selecting next first because it was not properly skipping new dbit entries.
This could result in lookups failing, e.g. after a change in max msgs per subject to a lower value.

Also fixed a bug that would not properly update our psim during compact when throwing away the whole block and a subject had more than one message.

Signed-off-by: Derek Collison derek@nats.io

Resolves: #4643

…s not skipping dbit entries.

This could result in lookups failing, e.g. after a change in max msgs per subject to a lower value.

Also fixed a bug that would not prperly update psim during compact when throwing away the whole block and a subject had more than one message.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner October 12, 2023 18:10
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 444a47e into main Oct 12, 2023
4 checks passed
@derekcollison derekcollison deleted the kv-bug branch October 12, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV Get/Watch fails even though key/value is present
2 participants