Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to flush may fail silently #1016

Closed
GeorgeEngland opened this issue Jul 14, 2022 · 1 comment
Closed

Calls to flush may fail silently #1016

GeorgeEngland opened this issue Jul 14, 2022 · 1 comment

Comments

@GeorgeEngland
Copy link

The flusher may fail a flush and it will not return the error to publish (since the flush happens asynchronously), nor will it alert the user to the error via an error callback.

The flusher should send this error to the user via an errorcallback.

Suggestion is in this MR
@kozlovic
Copy link
Member

Close with #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kozlovic @GeorgeEngland