Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPDATED] Align StreamSourceInfo schema with server #1039

Merged
merged 1 commit into from Aug 10, 2022
Merged

[UPDATED] Align StreamSourceInfo schema with server #1039

merged 1 commit into from Aug 10, 2022

Conversation

piotrpio
Copy link
Collaborator

Resolves #1038

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 85.559% when pulling 2f6bef5 on stream--source-update into c157d64 on main.

kozlovic
kozlovic approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs mentioned this pull request Aug 10, 2022
Closed
wallyqs
wallyqs approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was not sure about exposing APIError here since only being used for this type publicly but better to have some parity with the types from the server instead.

@kozlovic kozlovic merged commit eaaf39d into main Aug 10, 2022
@kozlovic kozlovic deleted the stream--source-update branch August 10, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream source info does not expose all fields sent by the server
4 participants
@piotrpio @coveralls @wallyqs @kozlovic