[ADDED] Filter streams by subject #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
force-pushed
the
strems-list-subject-filter
branch
from
ac69f50
to
2a42858
Compare
wallyqs
reviewed
Aug 31, 2022
js.go
Outdated
| @@ -359,6 +361,17 @@ func DirectGetNext(subject string) JSOpt { | |||
| }) | |||
| } | |||
|
|
|||
| // StreamListFilter is an option that can be used to configure `StreamsInfo()` and `StreamNames()` requests. | |||
| // It allows filtering the retured streams by subject associated with each stream. | |||
| // Wildcards can be used. For example, `StreamListFilter(FOO.>.A) will return | |||
There was a problem hiding this comment.
FOO.>.A is an invalid subject I think, maybe switch to the asterisk wildcard variant:
Suggested change
| // Wildcards can be used. For example, `StreamListFilter(FOO.>.A) will return | |
| // Wildcards can be used. For example, `StreamListFilter(FOO.*.A) will return |
There was a problem hiding this comment.
Thanks for catching that - fixed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1061