Some Updates #1073
Merged
Some Updates #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
This would have been useful for example I worked on that needed multiple replies. Signed-off-by: Derek Collison <derek@nats.io>
piotrpio
requested changes
Sep 12, 2022
kozlovic
requested changes
Sep 12, 2022
| @@ -7587,6 +7587,8 @@ func TestJetStreamSubscribeContextCancel(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestJetStreamClusterStreamLeaderChangeClientErr(t *testing.T) { | |||
| t.Skip("The 2.9 server changed behavior making this test fail now") | |||
There was a problem hiding this comment.
What is failing? And does that mean that the test is no longer relevant or that there is a breaking change? I don't remember changes in server that would explain that.
There was a problem hiding this comment.
Remember we were over zealous in responding from non-leaders in the server and changed that behavior to make some of the server tests pass consistently.
This test now does have timeouts for calls to StreamInfo.
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
updates
branch
from
0662081
to
cec1d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we prep post 2.9 release.
Signed-off-by: Derek Collison derek@nats.io