[ADDED] Listing buckets and bucket names #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekcollison not sure I get it. These methods list buckets only (as per #1008) |
|
Apologies, so this is to list all object stores in an account, got it. |
|
Yep, I think if that looks good it might be a good idea to do the same thing for KV buckets |
object.go
Outdated
| @@ -44,6 +44,10 @@ type ObjectStoreManager interface { | |||
| CreateObjectStore(cfg *ObjectStoreConfig) (ObjectStore, error) | |||
| // DeleteObjectStore will delete the underlying stream for the named object. | |||
| DeleteObjectStore(bucket string) error | |||
| // BucketNames is used to retrieve a list of bucket names | |||
| BucketNames(opts ...ObjectOpt) <-chan string | |||
There was a problem hiding this comment.
Maybe StoreNames and Stores?
There was a problem hiding this comment.
Hm, makes sense as we mostly use ObjectStore instead of Bucket elsewhere. What about ObjectStoreNames and ObjectStores? Just to make it more obvious when using JetStreamContext interface.
There was a problem hiding this comment.
We need to keep StreamsInfo but let's make alias for Streams() and that will be consistent imo.
|
Naming stuff is hard ;) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1008