Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] Listing Key Value stores and object stores to return status instead of interface #1099

Merged
merged 1 commit into from Oct 12, 2022

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented Oct 5, 2022

This PR addresses nats-io/nats-architecture-and-design#154

This PR changes the signatures of KeyValueStores() and ObjectStores() methods. For KV, this is not a breaking change since this functionality is yet to be released. For object store, this is a breaking change since these methods were released as part of v1.17.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 85.875% when pulling e6fe8b5 on change-kv-and-object-list into 1ee76ea on main.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with the change, but since this is a breaking change, I would recommend that we either release v1.18.0 "soon", or we start to post PR against a "dev" branch as opposed to main, so that we keep breaking changes out of main in case we need to provide a patch to existing version before being able to release the next minor release.

I don't think that there is anything wrong releasing v1.18.0 "just" after v1.17.0, especially that most of commits on main right now are [ADDED] or [CHANGED]. So if you think that the next release is going to be v1.18.0 (and not 1.17.1), then go ahead and merge. If not, let's create the "dev" branch and switch this PR against that branch.

@piotrpio
Copy link
Collaborator Author

piotrpio commented Oct 6, 2022

@kozlovic Got it, I think it makes sense to do the v1.18.0 release after merging this PR. What do you think about introducing a breaking change in object store's signature (that has already been released).

@ripienaar
Copy link
Contributor

Object store is still experimental so I think it’s fine

@piotrpio piotrpio merged commit 7d22790 into main Oct 12, 2022
@piotrpio piotrpio deleted the change-kv-and-object-list branch October 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants