Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve durable consumer unsubscribe comment #1100

Merged
merged 2 commits into from Oct 6, 2022

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Oct 5, 2022

Signed-off-by: Sylvain Rabot sylvain@abstraction.fr

Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
@coveralls
Copy link

coveralls commented Oct 5, 2022

Coverage Status

Coverage remained the same at 85.942% when pulling f79575e on sylr:js-durable-unsubscribe into 1ee76ea on nats-io:main.

js.go Outdated Show resolved Hide resolved
js.go Outdated Show resolved Hide resolved
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @piotrpio recommendations

Co-authored-by: Piotr Piotrowski <piotrpiotrowski94@gmail.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 2b03e25 into nats-io:main Oct 6, 2022
@sylr sylr deleted the js-durable-unsubscribe branch October 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants