Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InactiveThreshold comments #1106

Merged
merged 2 commits into from Oct 15, 2022
Merged

Update InactiveThreshold comments #1106

merged 2 commits into from Oct 15, 2022

Conversation

neilalexander
Copy link
Member

These hadn't been updated after nats-io/nats-server#3190 seemingly.

@neilalexander
Update InactiveThreshold comments
d5eb48b 
These hadn't been updated after nats-io/nats-server#3190 seemingly.
@coveralls
Copy link

coveralls commented Oct 14, 2022 •
edited

Coverage Status

Coverage increased (+0.06%) to 85.976% when pulling 0689e7a on neilalexander:patch-1 into 885ad13 on nats-io:main.

derekcollison
derekcollison approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Two nits on comments.

js.go Outdated Show resolved Hide resolved
js.go Outdated Show resolved Hide resolved
derekcollison
derekcollison approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@derekcollison derekcollison merged commit 888a91d into nats-io:main Oct 15, 2022
@piotrpio piotrpio mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@sylr sylr sylr approved these changes

@bruth bruth bruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neilalexander @coveralls @derekcollison @sylr @bruth