Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds response data types for latest ADR update #1173

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

ripienaar
Copy link
Contributor

Update for nats-io/nats-architecture-and-design#183

Signed-off-by: R.I.Pienaar rip@devco.net

@coveralls
Copy link

coveralls commented Dec 28, 2022

Coverage Status

Coverage: 85.473% (-0.03%) from 85.506% when pulling 75853e4 on ripienaar:micro_response_types into f2f17e6 on nats-io:main.

micro/service.go Outdated Show resolved Hide resolved
Signed-off-by: R.I.Pienaar <rip@devco.net>
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ripienaar
Copy link
Contributor Author

@piotrpio i fixed that, but somehow cant merge thought I was able to merge here, anyway its good to go if you want to merge.

@piotrpio piotrpio merged commit 07b2b8f into nats-io:main Dec 29, 2022
@ripienaar ripienaar deleted the micro_response_types branch December 29, 2022 14:07
@piotrpio piotrpio mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants