[CHANGED] Use interface instead of struct for micro.Request #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Dec 29, 2022
micro/request.go
Outdated
| } | ||
|
|
||
| // RequestHandler is a function used as a Handler for a service. | ||
| RequestHandler func(*Request) | ||
| RequestHandler func(Request) |
There was a problem hiding this comment.
Handler could be interface based here too a la http.Handler, that would make it convenient to pass around types that can handle requests, think something like this:
// micro.RequestHandler
type RequestHandler func(Request)
func (fn RequestHandler) Handle(req Request) {
fn(req)
}There was a problem hiding this comment.
Very good idea, thanks!
wallyqs
reviewed
Dec 29, 2022
wallyqs
reviewed
Jan 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micro.Requestto an interface