Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Pass opts to ConsumerInfo call in AddConsumer #1176

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[FIXED] Pass opts to ConsumerInfo call in AddConsumer #1176

merged 1 commit into from
Jan 4, 2023

Conversation

piotrpio
Copy link
Collaborator

Resolves #1161

@piotrpio piotrpio requested a review from Jarema December 30, 2022 09:38
@coveralls
Copy link

Coverage Status

Coverage: 85.462%. Remained the same when pulling 5046e70 on fix-add-consumer-context into 8630b7d on main.

@piotrpio piotrpio mentioned this pull request Dec 30, 2022
Closed
2 tasks
Jarema
Jarema approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit d50c137 into main Jan 4, 2023
@piotrpio piotrpio deleted the fix-add-consumer-context branch January 4, 2023 08:58
@piotrpio piotrpio mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JetStreamContext AddConsumer calls ConsumerInfo without passing context
3 participants
@piotrpio @coveralls @Jarema