Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go updates #1182

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Go updates #1182

merged 3 commits into from
Jan 5, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jan 5, 2023

  • Bump Travis version to include 1.18 and 1.19 (since Go 1.20 ETA is February)
  • Continue adoption of error wrapping syntax throughout the package
  • go module updates

derekcollison
derekcollison approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piotrpio
piotrpio approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wallyqs
Adopt error wrapping syntax for fmt.Errorf
a4c4900 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Update Go versions in Travis and go.mod
17d88bc 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Update golang.org/x/crypto version
8ab362f 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Copy link
Member Author

wallyqs commented Jan 5, 2023

Added another commit for the go crypto package that was released yesterday /cc @philpennock

@coveralls
Copy link

Coverage Status

Coverage: 85.488%. Remained the same when pulling 8ab362f on go-updates into d5a4d04 on main.

@wallyqs wallyqs merged commit ba8a129 into main Jan 5, 2023
@wallyqs wallyqs deleted the go-updates branch January 5, 2023 18:26
@piotrpio piotrpio mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@piotrpio piotrpio piotrpio approved these changes

@philpennock philpennock Awaiting requested review from philpennock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wallyqs @coveralls @derekcollison @piotrpio