Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPTIMIZE] optimize add consumer #1185

Merged
merged 1 commit into from
Jan 10, 2023
Merged

[OPTIMIZE] optimize add consumer #1185

merged 1 commit into from
Jan 10, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Jan 10, 2023

Optimize add consumer to not re-define the consumer if the consumer config is equal to the current consumer config

@jnmoyne jnmoyne requested a review from piotrpio January 10, 2023 08:29
@coveralls
Copy link

Coverage Status

Coverage: 85.283% (-0.2%) from 85.499% when pulling 4578025 on jnm/addconsumeroptimize into ba8a129 on main.

piotrpio
piotrpio approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit eada5ec into main Jan 10, 2023
@piotrpio piotrpio deleted the jnm/addconsumeroptimize branch January 10, 2023 08:44
@piotrpio piotrpio mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnmoyne @coveralls @piotrpio