-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid panic on schema request when no schemas were given #1195
Conversation
Signed-off-by: R.I.Pienaar <rip@devco.net>
@@ -984,6 +984,56 @@ func TestMonitoringHandlers(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestServiceNilSchema(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may be able to do this test in your existing loop based tests but i couldnt figure it out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having this as separate test is fine, those tests are pretty complicated as they are and adding new branches would make them unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -984,6 +984,56 @@ func TestMonitoringHandlers(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestServiceNilSchema(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having this as separate test is fine, those tests are pretty complicated as they are and adding new branches would make them unclear.
Signed-off-by: R.I.Pienaar rip@devco.net