Go 1.20 updates, add build tag for rand.Seed #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
commented
Feb 10, 2023
| func init() { | ||
| // This is not needed since Go 1.20 because now rand.Seed always happens | ||
| // by default (uses runtime.fastrand64 instead as source). | ||
| rand.Seed(time.Now().UnixNano()) |
There was a problem hiding this comment.
we don't need it now probably but from Go 1.19 it was possible to get call into fastrand64 like this: maphash.Bytes(maphash.MakeSeed(), nil)
There was a problem hiding this comment.
yes a new file to add the build tags so that this does not apply to Go +1.20
There was a problem hiding this comment.
ok so just copyright 2023..
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Go 1.20 and also deprecates use of rand.Seed in the client for Go +1.20 series since this is now always done by default (golang/go#54880)
Signed-off-by: Waldemar Quevedo wally@nats.io