New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] FetchBatch method to utilize non-blocking pull subscription requests #1211

Merged

piotrpio merged 6 commits into main from pull-subscribe-fetch-chan

Feb 15, 2023

Collaborator

piotrpio commented Feb 14, 2023

Resolves #1201

piotrpio force-pushed the pull-subscribe-fetch-chan branch from 8c67be1 to 1f68ed8 Compare

February 14, 2023 15:20


          [ADDED] FetchChan method to utilize non-blocking pull subscription re…

9db0304

…quests

piotrpio force-pushed the pull-subscribe-fetch-chan branch from 1f68ed8 to 9db0304 Compare

February 14, 2023 16:21

piotrpio requested review from wallyqs and Jarema

February 14, 2023 16:26

coveralls commented Feb 14, 2023 •

edited

Coverage: 85.403% (-0.1%) from 85.55% when pulling 1b84e26 on pull-subscribe-fetch-chan into 2805753 on main.

wallyqs reviewed

View reviewed changes

js.go Outdated Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js_test.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

test/js_test.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

test/js_test.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

js.go Show resolved Hide resolved


          Apply review comments

1071a46

piotrpio requested a review from wallyqs

February 15, 2023 12:34

wallyqs reviewed

View reviewed changes

js.go Outdated Show resolved Hide resolved

piotrpio and others added 3 commits

February 15, 2023 13:37


          Fix unchecked errors in test

9fb1d41


          Update comment

4394d0b

Co-authored-by: Waldemar Quevedo <wally@nats.io>


          Fix formatting

51374f6

wallyqs reviewed

View reviewed changes

test/js_test.go Show resolved Hide resolved

wallyqs reviewed

View reviewed changes

test/js_test.go Outdated Show resolved Hide resolved


          Fix race condition

1b84e26

wallyqs approved these changes

View reviewed changes

Member

wallyqs left a comment

LGTM!

piotrpio merged commit edb105c into main

piotrpio deleted the pull-subscribe-fetch-chan branch

February 15, 2023 14:18

piotrpio mentioned this pull request

Release v1.24.0 #1221

Merged

wallyqs changed the title ~~[ADDED] FetchChan method to utilize non-blocking pull subscription requests~~ [ADDED] FetchBatch method to utilize non-blocking pull subscription requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment