Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Stream and consumer name validation #1219

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[FIXED] Stream and consumer name validation #1219

merged 1 commit into from
Feb 23, 2023

Conversation

piotrpio
Copy link
Collaborator

Resolves #1218

@piotrpio piotrpio mentioned this pull request Feb 23, 2023
Closed
2 tasks
@piotrpio piotrpio force-pushed the fix-consumer-stream-name-validation branch from fd7d994 to ee59b42 Compare February 23, 2023 13:37
@piotrpio piotrpio force-pushed the fix-consumer-stream-name-validation branch from ee59b42 to 66c4c5d Compare February 23, 2023 13:38
@coveralls
Copy link

coveralls commented Feb 23, 2023 •
edited

Coverage Status

Coverage: 85.388% (+0.05%) from 85.334% when pulling 66c4c5d on fix-consumer-stream-name-validation into 07d83b8 on main.

Jarema
Jarema approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit b466aad into main Feb 23, 2023
@piotrpio piotrpio deleted the fix-consumer-stream-name-validation branch February 23, 2023 14:25
@piotrpio piotrpio mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

@wallyqs wallyqs Awaiting requested review from wallyqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to add Jetstream stream with space in name
3 participants
@piotrpio @coveralls @Jarema