avoid producing nil metadata #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite hard to validate in a way that allows object or nil using jsonschema so metadata should either be omitempty or always be object. During initial reviews we made it not omitempty, so this ensures its never nil. Can also make it omitempty if cleaner. Signed-off-by: R.I.Pienaar <rip@devco.net>
|
Tests are finally green, sorry I missed those failures @piotrpio |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite hard to validate in a way that allows object or nil using jsonschema so metadata should either be omitempty or always be object.
During initial reviews we made it not omitempty, so this ensures its never nil. Can also make it omitempty if cleaner.