[UPDATED] Compression library for Websocket #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
With compress/flate, it seems that after calling Close() it was fine dropping the last 4 bytes before doing the framing, but with the different flate, it fails. Instead, use Flush() (like in the server) and then dropping the last 4 bytes works as before. I have added a compression.Close() on connection close, after sending the CLOSE frame. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
A couple of failing tests, might be flappers or might be due to upgrade of underlying server. I doubt related to WS compression. |
|
Can someone take a look at |
|
I'll take a look at it |
|
I found some issues in object store and fixed them here: #1260. They had nothing to do with this PR, so I'll merge it now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io
Signed-off-by: Ivan Kozlovic ivan@synadia.com