Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Object store context put and get issues #1260

Merged
merged 1 commit into from
May 4, 2023
Merged

[FIXED] Object store context put and get issues #1260

merged 1 commit into from
May 4, 2023

Conversation

piotrpio
Copy link
Collaborator

@piotrpio piotrpio commented May 3, 2023

  • Fixed failing TestNoRaceObjectContextOpt test
  • Fixed Put purging partial object before acks for all sent chunks were received. This caused leftover chunks to be processed after purge
  • Fixed issue in Read where nil was returned instead of context error

@piotrpio piotrpio mentioned this pull request May 3, 2023
Merged
@piotrpio piotrpio force-pushed the fix-object-store branch 2 times, most recently from d9ef681 to 2b07cc9 Compare May 3, 2023 15:37
@coveralls
Copy link

coveralls commented May 3, 2023 •
edited

Coverage Status

Coverage: 85.064% (-0.06%) from 85.12% when pulling 2b91e61 on fix-object-store into d963c7d on main.

@piotrpio
[FIXED] Object store context put and get issues
2b91e61 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from wallyqs May 3, 2023 16:03
wallyqs
wallyqs approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit c3cae07 into main May 4, 2023
4 checks passed
@piotrpio piotrpio deleted the fix-object-store branch May 4, 2023 06:45
@piotrpio piotrpio mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotrpio @coveralls @wallyqs