Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConsumerName option, use similar ephemeral names as server #1263

Merged
merged 3 commits into from
May 12, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented May 12, 2023

No description provided.

Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@@ -2474,6 +2476,14 @@ func ConsumerMemoryStorage() SubOpt {
})
}

// ConsumerName sets the name for a consumer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use this and set it, it will still use long form create yes?

js.go Show resolved Hide resolved
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage: 85.276% (-0.09%) from 85.37% when pulling 1537c0b on consumer-name into d313991 on main.

@wallyqs wallyqs merged commit 2765665 into main May 12, 2023
4 checks passed
@piotrpio piotrpio mentioned this pull request May 23, 2023
@piotrpio piotrpio deleted the consumer-name branch June 8, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants