[CHANGED] Reload TLS certificates on reconnect #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
piotrpio
commented
May 12, 2023
piotrpio
commented
- Use callbacks when reconnecting to get current cert/key and CAs (similar to credentials)
- Send async error on failed connect (previously only protocol auth errors were reported)
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
tls-certs-reload
branch
from
4f0e88f
to
2782dde
Compare
wallyqs
reviewed
May 12, 2023
| } | ||
| if o.TLSConfig == nil { | ||
| o.TLSConfig = &tls.Config{MinVersion: tls.VersionTLS12} | ||
| } | ||
| o.TLSConfig.RootCAs = pool |
There was a problem hiding this comment.
I think we need to smoke test the callback at least once when building the option here, and return in case there is an error, otherwise it will fail until much later and fall into reconnect logic potentially hiding some of the errors.
wallyqs
reviewed
May 12, 2023
| @@ -2474,6 +2509,9 @@ func (nc *Conn) sendConnect() error { | |||
| // Read the rest now... | |||
| proto, err = nc.readProto() | |||
| if err != nil { | |||
| if !nc.initc && nc.Opts.AsyncErrorCB != nil { | |||
There was a problem hiding this comment.
These probably help would help with the visibility of the errors that I was mentioning above 👍, still think that might be better to just check that the callbacks won't work at config time (bad path to client cert) on connect than after connect init has started, otherwise I think last error on connect would be no servers available instead of the config error.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.