Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestJetStreamConcurrentQueueDurablePushConsumers test #1267

Merged
merged 2 commits into from
May 19, 2023

Conversation

piotrpio
Copy link
Collaborator

No description provided.

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@coveralls
Copy link

coveralls commented May 18, 2023

Coverage Status

Coverage: 85.271% (+0.04%) from 85.229% when pulling 7667996 on fix-flaky-test into 2c5733a on main.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit only.

js_test.go Show resolved Hide resolved
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema May 19, 2023 10:24
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 7c468cd into main May 19, 2023
4 checks passed
@piotrpio piotrpio deleted the fix-flaky-test branch May 19, 2023 11:19
@piotrpio piotrpio mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants