Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] JetStream Simplified API #1273

Merged
merged 27 commits into from
May 23, 2023
Merged

[ADDED] JetStream Simplified API #1273

merged 27 commits into from
May 23, 2023

Conversation

piotrpio
Copy link
Collaborator

This is a cleaned up version of #1018 with rearranged/squashed commits.

@piotrpio
Add simplified JetStream API with pull consumer
cda50b9
@piotrpio
Add DeleteMsg() and tests for stream operations
bda116f
@piotrpio
Verify if consumer is already streaming messages
8d42e82
@piotrpio
Add methods for listing streams and consumers
9a95847
@piotrpio
Add Jetstream error codes and improve error handling
e7d146c
@piotrpio
Add tests for parse.go
334dddc
@piotrpio
Move StreamConfig and ConsumerConfig to new package
c5dc4b8
@piotrpio
Add consumer tests when using cluster
cae5dbe
@piotrpio
Add connection event listeners
c580ecc 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Add helper method to listen for common stauts changes on a single cha…
b211cb2 
…nnel

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Changed to use variadic list of statuses
e17cf6a 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Make consumer create idempotent
8d9ad1b
@piotrpio
Add README.md for jetstream package
38381b4
@piotrpio
Move parse.go to internal directory
c8b7b4b
@piotrpio
Rename Stream() to Listen(), add NextNoWait method
f585c37
@piotrpio
Iterator for pull consumer, refine API and fix bugs
ac40332 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Add ordered consumer, FetchBytes and Next, rework options
e7ab93e 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Merge branch 'main' of https://github.com/nats-io/nats.go into jsv2
b31e5f6 
Improve readme

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>

Fix msg size calculation

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>

Add connection event listeners

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>

Fix leaky goroutines in tests

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Merge branch 'main' of https://github.com/nats-io/nats.go into jsv2
2396e9d
@piotrpio
Add direct get support
1647f5b 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Merge branch 'event-listeners' of https://github.com/nats-io/nats.go …
ab434cb 
…into jsv2
@piotrpio
Merge branch 'main' of https://github.com/nats-io/nats.go into jsv2
b13e32f
@piotrpio
Wrap text in README
ccd3a0d 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Fixes after rebase
d85ef5d 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio
Wrap README.md
8bd1b9f 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema May 23, 2023 13:36
@piotrpio piotrpio mentioned this pull request May 23, 2023
Closed
@piotrpio
Fix flaky test
5625a7f 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
Jarema approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

coveralls commented May 23, 2023 •
edited

Coverage Status

Coverage: 82.781% (-2.4%) from 85.175% when pulling 463a2e3 on jsv2-cleanup into c939dd1 on main.

@piotrpio piotrpio force-pushed the jsv2-cleanup branch 4 times, most recently from 2453f44 to df82934 Compare May 23, 2023 15:11
@piotrpio
Add coverage report for jetstream
26b4ed8 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio merged commit 524da3c into main May 23, 2023
2 of 3 checks passed
@piotrpio piotrpio deleted the jsv2-cleanup branch May 23, 2023 15:34
@piotrpio piotrpio mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotrpio @coveralls @Jarema