Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGED] More verbose endpoint info on INFO requests #1277

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

piotrpio
Copy link
Collaborator

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 10a535a into main Jun 7, 2023
1 of 2 checks passed
@piotrpio piotrpio deleted the micro-info-schema branch June 7, 2023 09:22
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oderwat
Copy link
Contributor

oderwat commented Jun 12, 2023

EDIT: I just realized that we need to recompile and deploy all our existing microservices to make that actually work.

@piotrpio
Copy link
Collaborator Author

@oderwat sorry for your trouble, so you're saying that the change works for you now? If not let me know, we'll be working on that!

@oderwat
Copy link
Contributor

oderwat commented Jun 12, 2023

@piotrpio this stuff works like a charm. I totally forgot that we needed to recompile the services and was puzzled for some minutes :)

P.S.: There is still the problem with #1307 (comment) and I can't find a reason for that.

@piotrpio
Copy link
Collaborator Author

@oderwat Glad it works fine. Regarding #1307 yes, I've seen it and will be looking at this tomorrow, hope that's ok with you

@oderwat
Copy link
Contributor

oderwat commented Jun 12, 2023

@piotrpio That is fine. I was just using the nighttime for trying some of the new stuff. The new API has time. The changes to micro were more important to me because we are having some parts of our system released in beta some days ago, and I am nervous and want to use the monitoring and continue writing and testing of the deployment daemon, which is based on the discovery through metadata.

@ripienaar
Copy link
Contributor

Nats CLI should have latest schemas in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants