[FIXED] Cleanup reply sub after putting object #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
wallyqs
reviewed
Jun 1, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| defer jetStream.(*js).cleanupReplySub() |
There was a problem hiding this comment.
qq, why do we have to type assert here?
There was a problem hiding this comment.
nc.JetStream() returns an interface, not *js so I could either add cleanupReplySub() as interface method or type assert here - I decided not to clutter the interface with another method (even unexported), but not sure which approach is better.
|
likely unrelated flapper but might be worth looking at: |
|
@wallyqs yeah, from what I saw that's a flapper and it's on the list :) |
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async reply subscription was created on each
object.Put()and not cleaned up. This PR closes this subscription afterPut()completes.