[CHANGED] Simplified JetStream API changes and improvements

[piotrpio]

• Fixed typo in PullThresholdBytes option
• Removed push consumer only fields from ConsumerConfig
• Removed context.Context from PublishAsync and PublishMsgAsync
• Renamed AddConsumer to CreateOrUpdateConsumer - this change is introduced in anticipation for separation of create and update operations in nats-server. After they'll be introduced, there will be 3 methods:
  • CreateOrUpdateConsumer() - current upsert behavior
  • CreateConsumer() - will not overwrite consumer
  • UpdateConsumer() - will fail if consumer does not exist

[Jarema]

Looks good, but before LGTM:

Are we 100% sure, that in few months, we will not regret not having context in publish async? :)

[piotrpio]

@Jarema I don't think so since we are not waiting for response from the server in the method itself, so really there is nothing to be canceled here.

[derekcollison]

IIRC we could block PublishAsync based on the outstanding ack window.

[wallyqs]

LGTM