Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consumer on OrderedConsumer, add missing tests #1317

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

piotrpio
Copy link
Collaborator

  • Previously client was lazily initializing consumer when OrderedConsumer was used, but that made Info() return an error if invoked before consuming messages
  • Added some missing unit tests

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema June 14, 2023 14:15
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 7c2bded into main Jun 23, 2023
2 checks passed
@piotrpio piotrpio deleted the add-jetstream-tests branch June 23, 2023 07:19
@tpihl
Copy link

tpihl commented Jun 29, 2023

@piotrpio, a reflection;

All tests (as I read them) are trying the scenario where the stream AND the consumer is created before the msg(s) is emitted to the stream.

Can that order make a difference, i.e. create stream, emit msg(s) and THEN create consumer. I think this is the much more common scenario, the "start with empty stream" is only the corner-case just when stream was created.

Just a reflection; T

@piotrpio
Copy link
Collaborator Author

@tpihl Good point, I will add such tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants