Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds nats-server dev + main branches to CI testing #1336

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Adds nats-server dev + main branches to CI testing #1336

merged 2 commits into from
Jun 27, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 26, 2023

Upgrades default go_test.mod version for testing too.

@wallyqs
Test using dev + main nats-server branches
d660b48 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs
Update nats-server used for tests
c241feb 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested review from piotrpio and Jarema June 26, 2023 19:58
piotrpio
piotrpio approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Failing test on dev looks to be caused by nats.go not having subject transform changes merged to main.

@wallyqs wallyqs merged commit 67b8ef9 into main Jun 27, 2023
2 checks passed
@piotrpio piotrpio mentioned this pull request Jul 20, 2023
Merged
@piotrpio piotrpio deleted the test-more-servers branch September 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wallyqs @piotrpio