fixed + slightly enhanced the basic example in jetstream package #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am package README.md, so that it compiles and completes with all messages arriving.
piotrpio
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Thanks for the PR!
You have some valid points, although I do not think this should really be used as a standalone example, because it is mixing several concepts that don't really work together well. A goad of Basic usage was more to showcase various ways of interacting with the consumer.
That being said, better to have an example which works, so LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to get started with jetstream, I couldn't compile the basic example that was given in the
README.md. One of the variables was never read (var msg jetstream.Msg), one check for a bool was not against a bool (if msgs.Error() {),consis actually not the consumer butcis (it, _ := cons.Messages()), and a few more things (see new code).I also made it clear in the console output which receiving type was used to get the particular message (fetch vs. callback vs. iterator).
This now compiles fine, and the crude loop at the end also waits for all test messages to be received as well. Dirty (like omitting all checks for
err), but it should be enough to grasp the basic concepts.